This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Make --azure-container-registry-config optional #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yolo3301! Could you kindly (1) update documentation and add unit tests for this override, or (2) grant me access to push to this PR, in which case I'm happy to quickly do that. |
|
@jackfrancis I added test cases but not sure which document to update. I added you as a collaborator in my repo. You can update this branch if that's easier. |
ghost
assigned 
jackfrancis
force-pushed
the
optional_registry
branch
from
0b60ddb to
98705c7
Compare
jackfrancis
force-pushed
the
optional_registry
branch
from
98705c7 to
f17954e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: