This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Resubmit PR# 2332: Enable colorized logging on Windows #2482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is resubmitting my previous PR #2332. I tried out @jackfrancis's updates and they work really well. I had to delete my fork for another reason so I needed to recreate the PR with the cumulative changes.
What this PR does / why we need it: On Windows, logging prints escape codes that do not render properly. I used a workaround suggested in https://github.com/mattn/go-colorable.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: