This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
add timeout to restart docker #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jackfrancis
reviewed
Mar 13, 2018
| @@ -202,6 +202,8 @@ function ensureFilepath() { | |||
| fi | |||
| } | |||
|
|
|||
| function retrycmd_if_failure() { retries=$1; wait=$2; shift && shift; for i in $(seq 1 $retries); do ${@}; [ $? -eq 0 ] && break || sleep $wait; done; echo Executed \"$@\" $i times; } | |||
There was a problem hiding this comment.
FYI it must be this line that is breaking things, should we revert to the bash-compatible version and retry?
CecileRobertMichon
force-pushed
the
retry-restart-docker
branch
from
8079811 to
184090d
Compare
CecileRobertMichon
changed the title
CecileRobertMichon
force-pushed
the
retry-restart-docker
branch
from
37d40dc to
a4e4f40
Compare
added 4 commits
March 16, 2018 13:13
CecileRobertMichon
force-pushed
the
retry-restart-docker
branch
from
83312b8 to
ae253db
Compare
added 4 commits
March 16, 2018 14:48
This reverts commit a5373c4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: add a retry to
systemctl restart dockercommand to guard against stuck commandWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: