This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Deregister node in api server during cordon-and-drain #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jackfrancis
reviewed
Mar 12, 2018
pkg/operations/cordondrainvm.go
Outdated
| @@ -62,7 +62,16 @@ func SafelyDrainNode(az armhelpers.ACSEngineClient, logger *log.Entry, masterURL | |||
|
|
|||
| //Evict pods in node | |||
| drainOp := &drainOperation{client: client, node: node, logger: logger, timeout: timeout} | |||
| return drainOp.deleteOrEvictPodsSimple() | |||
| if err = drainOp.deleteOrEvictPodsSimple(); err != nil { | |||
There was a problem hiding this comment.
The original usage of return drainOp.deleteOrEvictPodsSimple() is preferred here.
added 2 commits
March 12, 2018 15:08
dmitsh
changed the title
tesharp
pushed a commit
to tesharp/acs-engine
that referenced
this pull request
Mar 16, 2018
* Deregister node in api server (optionally) during cordon-and-drain * addressed comments * added warning message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrade operation, the api server sometimes lists already deleted nodes.
Adding explicit call to deregister nodes during cordon-and-drain.