This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Scale windows VM bug: catch error for len(vms) < 1 #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 15, 2018 15:47
This reverts commit 3ffca42.
jackfrancis
reviewed
Jan 16, 2018
cmd/scale.go
Outdated
| @@ -188,6 +188,9 @@ func (sc *scaleCmd) run(cmd *cobra.Command, args []string) error { | |||
| vms, err := sc.client.ListVirtualMachines(sc.resourceGroupName) | |||
| if err != nil { | |||
| log.Fatalln("failed to get vms in the resource group. Error: %s", err.Error()) | |||
| } else if len(*vms.Value) < 1 { | |||
| // TODO fix bug: clusters with windows vms always fail here | |||
There was a problem hiding this comment.
Let's remove this TODO line. I think checking for the length of the response is general, and any existing bugs that expose this symptom are coincidental.
ghost
assigned
jackfrancis
approved these changes
Jan 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This is a temporary fix which catches the error where ListVirtualMachines returns 0 for a resource group. This causes scale operations to fail for clusters with windows nodes as reported by #1972.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: