This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix k8s 1.6 regression #2049
Merged
Fix k8s 1.6 regression #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jackfrancis
reviewed
Jan 12, 2018
| @@ -88,7 +88,10 @@ func setAPIServerConfig(cs *api.ContainerService) { | |||
|
|
|||
| // RBAC configuration | |||
| if helpers.IsTrueBoolPointer(o.KubernetesConfig.EnableRbac) { | |||
| defaultAPIServerConfig["--authorization-mode"] = "Node,RBAC" | |||
| defaultAPIServerConfig["--authorization-mode"] = "RBAC" | |||
| if isKubernetesVersionGe(o.OrchestratorVersion, "1.7.0") { | |||
There was a problem hiding this comment.
We need this same version guard in the defaultAPIServerConfig assignment above as well.
added 2 commits
January 12, 2018 16:06
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Only add Node authorization-mode to default api-server config if the k8s version is greater or equal to 1.7.0
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: