Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

generic k8s config interfaces cleanup #2033

Merged
merged 1 commit into from
Jan 10, 2018
Merged

generic k8s config interfaces cleanup #2033

merged 1 commit into from
Jan 10, 2018

Conversation

jackfrancis
Copy link
Member

What this PR does / why we need it: Collapses common functions into a common one, removes an unused function.

Release note:

NONE

@ghost ghost assigned jackfrancis Jan 10, 2018
@ghost ghost added the in progress label Jan 10, 2018
CecileRobertMichon
CecileRobertMichon approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

JunSun17
JunSun17 approved these changes Jan 10, 2018
View reviewed changes
Copy link
Collaborator

@JunSun17 JunSun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, look good to me.

@jackfrancis jackfrancis merged commit f66ba4c into Azure:master Jan 10, 2018
@ghost ghost removed the in progress label Jan 10, 2018
@jackfrancis jackfrancis deleted the k8s-config-getters branch January 10, 2018 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JunSun17 JunSun17 JunSun17 approved these changes

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

Assignees

@jackfrancis jackfrancis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackfrancis @CecileRobertMichon @JunSun17