Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Adds to the dcos windows host name to indicate pub and priv agent #2023

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

yakman2020
Copy link
Contributor

What this PR does / why we need it:
Adds either the character "w" or "wp" to the hostname of dcos windows agents to make it possible to identify them given the hostname, in a manner similar to dcos linux host names but respecting the windows name limits.

Special notes for your reviewer:
Mesosphere needs this for their CI process.
Release note:

@ghost ghost assigned yakman2020 Jan 10, 2018
@ghost ghost added the in progress label Jan 10, 2018
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit 24c19e0 into master Jan 10, 2018
@ghost ghost removed the in progress label Jan 10, 2018
@jackfrancis jackfrancis deleted the brcampbe-winhost branch January 10, 2018 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants