This repository was archived by the owner on Jan 11, 2023. It is now read-only.
E2E runner: stabilize Windows tests #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -309,6 +313,7 @@ func (p *Pod) CheckWindowsOutboundConnection(sleep, duration time.Duration) (boo | |||
| log.Printf("Error:%s\n", err) | |||
| log.Printf("Out:%s\n", out) | |||
| } | |||
| time.Sleep(sleep) | |||
jackfrancis
changed the title
anhowe
reviewed
Jan 5, 2018
| } else { | ||
| Skip("No linux agent was provisioned for this Cluster Definition") | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| Describe("with a windows agent pool", func() { | ||
| It("should be able to deploy an iis webserver", func() { | ||
| /*It("should be able to deploy an iis webserver", func() { |
There was a problem hiding this comment.
can we just delete this instead of commenting out? or if you intend to re-enable someday, add a TODO with the conditions of when this should be uncommented.
There was a problem hiding this comment.
Will add a TODO, thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Cleaning up created resources is a necessary tidying strategy for re-running E2E tests against a long-running cluster. Additionally:
kubernetes-dashboardpod twiceRelease note: