-
Notifications
You must be signed in to change notification settings - Fork 558
change flexvolume plugin dir to /etc/kubernetes/volumeplugins in Linux #1991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@andyzhangx just merged the Windows flex volume PR, so you'll need to rebase this one :) |
a8fb40d
to
d1f371e
Compare
@JiangtianLi confilict resolved |
@@ -30,14 +30,15 @@ ExecStart=/usr/bin/docker run \ | |||
--volume=/etc/kubernetes/:/etc/kubernetes:ro \ | |||
--volume=/srv/kubernetes/:/srv/kubernetes:ro $DOCKER_OPTS \ | |||
--volume=/var/lib/waagent/ManagedIdentity-Settings:/var/lib/waagent/ManagedIdentity-Settings:ro \ | |||
--volume=/usr/libexec/kubernetes/kubelet-plugins:/usr/libexec/kubernetes/kubelet-plugins:rw \ | |||
--volume=/etc/kubernetes/volumeplugins:/etc/kubernetes/volumeplugins:rw \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be done for the 1.5 kuberneteskubelet.service as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I mean in parts/k8s/artifacts/1.5/kuberneteskubelet.service)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anhowe k8s 1.5 does not support flexvolume, so it's not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jackfrancis |
/retest |
It seems the test suite has kicked off but there is no log of any spec. It is weird that hybrid 1.7 test passed, which uses the same v1.7.12-1int.zip. Seems to me the test suite is stuck right after |
Will merge, overlooking flaky Windows E2E runs for this PR. Thanks again @andyzhangx ! |
What this PR does / why we need it:
change default flexvolume plugin dir to
/etc/kubernetes/volumeplugins
in Linux since original default flexvolume plugin dir/usr/libexec/kubernetes/kubelet-plugins
does not work in coreos according to #1957(in Windows, the plugin dir would be
c:\k\volumeplugins
)Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #1957Special notes for your reviewer:
@jackfrancis @JiangtianLi @mwieczorek @IvanovOleg
Release note: