Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

add etcd encryption at rest #1973

Merged
merged 2 commits into from
Jan 3, 2018
Merged

add etcd encryption at rest #1973

merged 2 commits into from
Jan 3, 2018

Conversation

pidah
Copy link
Contributor

@pidah pidah commented Dec 29, 2017

What this PR does / why we need it:
This PR adds an option to enable kubernetes data encryption at rest (disabled by default as it is currently an alpha feature). This complements #1929 which encrypts etcd communication on the wire. More information is available here: https://kubernetes.io/docs/tasks/administer-cluster/encrypt-data/

@ghost ghost assigned jackfrancis Jan 2, 2018
@ghost ghost added the in progress label Jan 2, 2018
@pidah
Copy link
Contributor Author

pidah commented Jan 2, 2018

Nice @jackfrancis 😊

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit a30d445 into Azure:master Jan 3, 2018
@ghost ghost removed the in progress label Jan 3, 2018
content: |
apiVersion: v1
kind: Config
kind: EncryptionConfig
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 kind fields?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @mrosterm is right. @pidah could you submit a follow-up PR to remove the kind: Config line? Based on the docs you provided that's the resource type we want.

Thanks both!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackfrancis sorry just saw this, will raise a fix PR.

@amit-kumar-4 amit-kumar-4 deleted the etcdEncryption branch April 13, 2018 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants