Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Updates to kubelet flags. #1942

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Updates to kubelet flags. #1942

merged 3 commits into from
Jan 3, 2018

Conversation

brendandburns
Copy link
Member

  • disable read-only port
  • enforce kernel settings
  • don't keep terminated pod volumes

@ghost ghost assigned brendandburns Dec 15, 2017
@ghost ghost added the in progress label Dec 15, 2017
anhowe
anhowe previously approved these changes Dec 15, 2017
Copy link
Contributor

@anhowe anhowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis
Copy link
Member

@brendanburns --protect-kernel-defaults option enforcement yields this message on a 1.7-built cluster:

kubelet.go:1323] Failed to start ContainerManager [Invalid kernel flag: vm/overcommit_memory, expected value: 1, actual value: 0, Invalid kernel flag: kernel/panic, expected value: 10, actual value: 0, Invalid kernel flag: kernel/panic_on_oops, expected value: 1, actual value: 0]

I'm going to triage that option out of this PR and create a backlog issue to look into kernel defaults as a separate work item.

@jackfrancis jackfrancis merged commit 8d5fba9 into Azure:master Jan 3, 2018
@ghost ghost removed the in progress label Jan 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants