This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Kubernetes v1.9.0 support #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
karataliu
reviewed
Dec 7, 2017
pkg/acsengine/k8s_versions.go
Outdated
| @@ -8,6 +8,33 @@ import ( | |||
|
|
|||
| // KubeConfigs represents Docker images used for Kubernetes components based on Kubernetes versions (major.minor.patch) | |||
| var KubeConfigs = map[string]map[string]string{ | |||
| common.KubernetesVersion1Dot9Beta1: { | |||
| "hyperkube": "hyperkube-amd64:v1.9.0-beta.1", | |||
| "ccm": "cloud-controller-manager-amd64:v1.9.0", | |||
There was a problem hiding this comment.
Here should be 'cloud-controller-manager-amd64:v1.9.0-beta.1'.
Another thing to note is azure's 'ccm' image release is planned to be shipped via public dockerhub, which does not share 'gcrio.azureedge.net' prefix then. This could be addressed later when we move to that image.
jackfrancis
changed the title
JiangtianLi
previously approved these changes
Dec 21, 2017
pkg/acsengine/k8s_versions.go
Outdated
| "pause": "pause-amd64:3.0", | ||
| DefaultTillerAddonName: DefaultTillerImage, | ||
| DefaultReschedulerAddonName: DefaultReschedulerImage, | ||
| "windowszip": "v1.8.4-1int.zip", // TODO add Windows image |
There was a problem hiding this comment.
You can change to v1.9.0-1int.zip
JiangtianLi
reviewed
Dec 21, 2017
pkg/api/common/const.go
Outdated
| @@ -147,6 +150,7 @@ var AllKubernetesWindowsSupportedVersions = map[string]bool{ | |||
| KubernetesVersion1Dot8Dot1: true, | |||
| KubernetesVersion1Dot8Dot2: true, | |||
| KubernetesVersion1Dot8Dot4: true, | |||
| // TODO add KubernetesVersion1Dot9Dot0 when Windows image is built | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: brings Kubernetes v1.9.0 support
Release note: