This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
setting default etcd version to v2.3.8 #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
commented
Nov 29, 2017
| @@ -349,11 +349,6 @@ func setOrchestratorDefaults(cs *api.ContainerService) { | |||
| } | |||
| } | |||
|
|
|||
| // default etcd version | |||
There was a problem hiding this comment.
These lines are unreachable code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: upgrade default etcd version to v2.3.8
Special notes for your reviewer: This is the latest v2 release of etcd:
https://github.com/coreos/etcd/releases/tag/v2.3.8
Release note: