This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
making the error body be returned on deployment errors from arm in pr… #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
weinong
reviewed
Nov 20, 2017
cmd/deploy.go
Outdated
| nil) | ||
| if err != nil { | ||
| nil); err != nil { | ||
| b, _ := json.Marshal(res) |
There was a problem hiding this comment.
does it provide value? json.Marshal() does not serialize the response body...
|
@weinong this time I actually caused a preflight valdiation error and valdiated the response body gets printed. Mostly is redundant with the error message but could technically be different depending on the message |
weinong
approved these changes
Nov 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eflight
What this PR does / why we need it:
makes preflight errors in the deployment be returned from the arm helper so above code can return them/act on them