Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

allow disabling dashboard addon in kubernetes cluster #1754

Merged
merged 8 commits into from
Nov 12, 2017

Conversation

dmitsh
Copy link

@dmitsh dmitsh commented Nov 10, 2017

allow disabling dashboard addon in kubernetes cluster

@ghost ghost assigned dmitsh Nov 10, 2017
@ghost ghost added the in progress label Nov 10, 2017
@dmitsh dmitsh requested a review from amanohar November 11, 2017 05:05
weinong
weinong previously approved these changes Nov 11, 2017
Copy link
Contributor

@amanohar amanohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Does this test run with both dashboard enabled/disabled to verify the change?

@jackfrancis
Copy link
Member

@amanohar see my latest commit which adds this scenario to set of regression tests

@amanohar amanohar dismissed their stale review November 12, 2017 20:44

Remove my review.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit bd006fc into Azure:master Nov 12, 2017
@ghost ghost removed the in progress label Nov 12, 2017
@dmitsh dmitsh deleted the ds-select-addons branch November 13, 2017 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants