This repository was archived by the owner on Jan 11, 2023. It is now read-only.
changing deployment name #1718
Merged
changing deployment name #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@dmitsh ptal |
jackfrancis
reviewed
Nov 7, 2017
| @@ -235,6 +235,9 @@ func (c *Cluster) AppCount() (int, error) { | |||
| // Version will return the node count for a dcos cluster | |||
| func (c *Cluster) Version() (string, error) { | |||
| out, err := c.Connection.Execute("curl -s http://localhost:80/dcos-metadata/dcos-version.json") | |||
| if err != nil { | |||
There was a problem hiding this comment.
we were getting lint warning ...
Do you suggest a separate PR?
There was a problem hiding this comment.
Nah, it's fine, strange that it should choose this PR to complain about that!
There was a problem hiding this comment.
So my CI build failed with make test-style. And I fixed all the things it complained about. This showed up as a warning. And my guess is that it has been ignored all this while. Also that check is needed. We are calculating err and not using it.
dmitsh
previously approved these changes
Nov 7, 2017
dmitsh
approved these changes
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Changes the way deployment name is computed
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Currently ARM deployment names do not have a cap for 64 characters. Changing the way this name is computed. Making it a function of time/suffix.
Special notes for your reviewer:
Release note: