This repository was archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jchauncey how do we go about adding k8s-1.8-release-e2e to circle? |
feat(windows): Add build steps for 1.8 windows binaries feaut(acs-engine): Add missing releasetoversion for 1.8
The node roles aren't showing up because the labels aren't being correctly added. I needed to manually do this. Will fix
|
JiangtianLi
suggested changes
Sep 29, 2017
# adeb88d774 Use adapter vEthernet (HNSTransparent) on Windows host network to find node IP | ||
# 02549d6647 Merge pull request #50914 from shyamjvs/add-logging-to-logdump | ||
|
||
git cherry-pick 02549d6647..45ba7bb0fb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change commit after I cherry-pick and push. Also please use git cherry-pick a^..b, which is easy to read.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Kubernetes 1.8. It doesn't however add it to the upgrade logic in acs-engine.