Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

feat(runner.go): port bash ginkgo runner to go #1365

Merged
merged 5 commits into from
Aug 30, 2017
Merged

feat(runner.go): port bash ginkgo runner to go #1365

merged 5 commits into from
Aug 30, 2017

Conversation

jchauncey
Copy link

@jchauncey jchauncey commented Aug 29, 2017 •
edited
Loading

  • Ports bash runner to golang
  • Updates the version check for the k8s test so that it uses the version specified in the cluster definition if provided
  • Adds some retry logic to the pod networking test since that was failing locally
  • Adds retry logic when provisioning fails (up to 3 times overridden using PROVISION_RETRIES)

This change is Reviewable

@jchauncey jchauncey self-assigned this Aug 29, 2017
@ghost ghost added the in progress label Aug 29, 2017
@msftclas
Copy link

@jchauncey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ghost ghost added the in progress label Aug 29, 2017
@jchauncey jchauncey closed this Aug 29, 2017
@jchauncey jchauncey reopened this Aug 29, 2017
@msftclas
Copy link

@jchauncey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ghost ghost added the in progress label Aug 29, 2017
Jonathan Chauncey added 5 commits August 30, 2017 13:45
feat(runner.go): port bash ginkgo runner to go
24935a4 
* Ports bash runner to golang
* Updates the version check for the k8s test so that it uses the version specified in the cluster definition if provided
* Adds some retry logic to the pod networking test since that was failing locally
ref(runner.go, kubernetes_test.go):
1288761 
* Refactored runner.go into a few more methods to help readability
* Fixed orchestrator version test for k8s.
* You can now set ORCHESTRATOR_RELEASE as an env var to provision clusters with a given release
fix(runner.go): Remove unused const
442915e
feat(runner.go): Add provision retries
f984632 
* We will now retry upto 3 times by default (override using PROVISION_RETRIES env var)
fix(runner.go): Remove excessive teardown calls
66203e7
jackfrancis
jackfrancis approved these changes Aug 30, 2017
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackfrancis jackfrancis merged commit 2f1fc77 into Azure:master Aug 30, 2017
@ghost ghost removed the in progress label Aug 30, 2017
@jchauncey jchauncey deleted the new-runner branch August 30, 2017 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

Assignees

@jchauncey jchauncey

Labels
area/ci size/small waiting for ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchauncey @msftclas @jackfrancis