bump k8s 1.6 release channel to version 1.6.9 #1343

jackfrancis · 2017-08-24T17:56:18Z

What this PR does / why we need it: Upgrades default 1.6 version of kubernetes to v1.6.9.

See: https://github.com/kubernetes/kubernetes/releases/tag/v1.6.9

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1200

Release note:

Kubernetes v1.6.9 is the default 1.6 version for new clusters

This change is

seanknox · 2017-08-24T17:58:09Z

@jackfrancis v1.6.9 just came out, let's make that the default if you're ok with it.

jackfrancis · 2017-08-24T18:04:55Z

@seanknox Do we have a windows tarball for 1.6.9?

seanknox · 2017-08-24T18:08:42Z

I'll try building one now...paging @JiangtianLi in the likely chance I screw it up. :)

jackfrancis · 2017-08-24T18:11:54Z

@seanknox Let me know when a v1.6.9intwinnat.zip artifact is ready and I'll kick off E2E, thanks!

JiangtianLi · 2017-08-24T18:17:21Z

@seanknox Are you building 1.6.9 out of https://github.com/Azure/kubernetes/commits/release-1.6? I assume release-1.6 has 1.6.9 already?

seanknox · 2017-08-24T18:28:40Z

Are you building 1.6.9 out of https://github.com/Azure/kubernetes/commits/release-1.6? I assume release-1.6 has 1.6.9 already?

I'll be building from Azure/kubernetes, yes. We forked before v1.6.9 was released upstream; going to try rebasing our fork and will report back.

seanknox · 2017-08-24T19:32:17Z

@jackfrancis @JiangtianLi built and uploaded v1.6.9intwinnat.zip, just kicked off e2e.

JiangtianLi

LGTM

seanknox · 2017-08-25T00:52:32Z

Update: think the Windows zip should be good at this point, ran into caching issues with our CDN. Will revisit tomorrow.

seanknox · 2017-08-25T02:02:38Z

Windows VMs and K8s components appeared to come up, but looks like the Windows container deployment failed. I can look more tomorrow, @JiangtianLi would appreciate your help figuring this one out...

seanknox · 2017-08-26T00:28:10Z

@jackfrancis @JiangtianLi @jchauncey I'm stumped why Windows e2e keeps failing here. I manually tested a cluster from this branch using acs-engine; Windows containers start and outbound internet appears to work.

JiangtianLi · 2017-08-26T00:30:56Z

@seanknox Do we have logs from e2e test?

seanknox · 2017-08-26T00:36:33Z

@JiangtianLi I canceled the build when I saw the failures which unfortunately doesn't save log artifacts (d'oh), kicked off e2e and will let it run all through this time.

… picks For some reason, the first of our custom commits in release-1.6 (5fa0725025) was not being applied on our range of cherry-pick commits. Using the preceding commit fixes this for a reason still unclear to me.

seanknox · 2017-09-01T05:29:03Z

Previous build succeeded, recent one failed due to what looks to be a transient Azure network error. Restarting.

++ kubectl exec win-webserver-1541187005-7ndp0 -- powershell iwr -UseBasicParsing -TimeoutSec 60 www.bing.com
++ grep StatusCode
iwr : The remote name could not be resolved: 'www.bing.com'
At line:1 char:1
+ iwr -UseBasicParsing -TimeoutSec 60 www.bing.com
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt 
   pWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe 
   ll.Commands.InvokeWebRequestCommand

JiangtianLi · 2017-09-01T05:27:55Z

scripts/build-windows-k8s.sh


-	git cherry-pick 5fa0725025..232fa6e5bc
+	git cherry-pick 79cf9963f7..232fa6e5bc


Do you need to update k8s_17_cherry_pick too?

No, v1.7 cherry-pick is working fine (we merged another PR that bumped Windows to v1.7.5 today).

@seanknox Did we push the build branch for v1.7? I didn't seem to find it although I found v1.6. If not, could we push v1.7 too, just to make sure we have all the commits in.

JiangtianLi · 2017-09-01T05:31:04Z

pkg/acsengine/const.go

@@ -133,7 +133,7 @@ var KubeConfigs = map[string]map[string]string{
 		"dnsmasq":         "k8s-dns-dnsmasq-amd64:1.13.0",
 		"pause":           "pause-amd64:3.0",
 		"tiller":          DefaultTillerImage,
-		"windowszip":      "v1.6.6intwinnat.zip",
+		"windowszip":      "v1.6.9-3intwinnat.zip",


I think we should use v1.6.9-1 and not bump up since previous versions are just for experiment and not usable. There is no point to publish previous versions.

I'm not sure it really matters as they're internal artifacts and not referenced in any user documentation or code. Ultimately all we're declaring here is "use this specific zip artifact when provisioning Windows nodes." Plus, given the long turn around with CDN caching we want to feel able to change this.

I agree that this it doesn't matter what filename we use for this release. However, we should fix our process going forward where we test our way through this by referring to non-CDN experimental versions, and then only once we have a verified working artifact do we update to a CDN-consuming destination.

The caveat is that there is no good way to tell the difference between bad and good zip artifact from the cluster after it is deployed, and it would be hard for ACI team and us to root cause the issue if not from the zip version. But with CDN long delay, I agree this should not block us and we can improve next time.

… picks

seanknox · 2017-09-01T20:26:58Z

msftclas added the cla-not-required label Aug 24, 2017

ghost assigned jackfrancis Aug 24, 2017

ghost added the in progress label Aug 24, 2017

jackfrancis mentioned this pull request Aug 24, 2017

Support Kubernetes v1.6.8, make default version #1201

Closed

jackfrancis changed the title ~~bumped k8s 1.6 release channel to version 1.6.8~~ WIP - bump k8s 1.6 release channel to version 1.6.9 Aug 24, 2017

JiangtianLi previously approved these changes Aug 24, 2017

View reviewed changes

seanknox dismissed JiangtianLi’s stale review via d8aef11 August 26, 2017 00:01

ghost assigned seanknox Aug 26, 2017

jackfrancis and others added 8 commits August 31, 2017 14:43

bumped k8s 1.6 release channel to version 1.6.8

b800459

update api constants

3cabf82

bumping to v1.6.9

a5311e4

fix(k8s windows): refer to specific patch version for Windows zips

7179eb4

fix(k8s windows): use newly build Windows k8s zip

4652338

chore(k8s windows): push acs branch to Azure/kubernetes fork

4486870

fix(windows k8s): add proper exit codes

7346525

JiangtianLi suggested changes Sep 1, 2017

View reviewed changes

fix(windows k8s): use earlier commit in release-1.7 branch for cherry…

5f258b0

… picks

JiangtianLi previously approved these changes Sep 1, 2017

View reviewed changes

fix(k8s windows): use newly build Windows k8s zip for v1.7

d32028d

seanknox dismissed JiangtianLi’s stale review via d32028d September 1, 2017 18:14

JiangtianLi approved these changes Sep 1, 2017

View reviewed changes

jackfrancis merged commit 343774d into Azure:master Sep 1, 2017

ghost removed the in progress label Sep 1, 2017

jackfrancis deleted the k8s-1.6.8-bump branch September 1, 2017 20:22

jackfrancis changed the title ~~WIP - bump k8s 1.6 release channel to version 1.6.9~~ bump k8s 1.6 release channel to version 1.6.9 Sep 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump k8s 1.6 release channel to version 1.6.9 #1343

bump k8s 1.6 release channel to version 1.6.9 #1343

jackfrancis commented Aug 24, 2017 •

edited by seanknox

Loading

seanknox commented Aug 24, 2017

jackfrancis commented Aug 24, 2017

seanknox commented Aug 24, 2017

jackfrancis commented Aug 24, 2017

JiangtianLi commented Aug 24, 2017

seanknox commented Aug 24, 2017

seanknox commented Aug 24, 2017

JiangtianLi left a comment

seanknox commented Aug 25, 2017

seanknox commented Aug 25, 2017

seanknox commented Aug 26, 2017 •

edited

Loading

JiangtianLi commented Aug 26, 2017

seanknox commented Aug 26, 2017

seanknox commented Sep 1, 2017

JiangtianLi Sep 1, 2017

seanknox Sep 1, 2017

JiangtianLi Sep 1, 2017

JiangtianLi Sep 1, 2017

seanknox Sep 1, 2017 •

edited

Loading

jackfrancis Sep 1, 2017

JiangtianLi Sep 1, 2017

seanknox commented Sep 1, 2017


		git cherry-pick 5fa0725025..232fa6e5bc
		git cherry-pick 79cf9963f7..232fa6e5bc

bump k8s 1.6 release channel to version 1.6.9 #1343

bump k8s 1.6 release channel to version 1.6.9 #1343

Conversation

jackfrancis commented Aug 24, 2017 • edited by seanknox Loading

seanknox commented Aug 24, 2017

jackfrancis commented Aug 24, 2017

seanknox commented Aug 24, 2017

jackfrancis commented Aug 24, 2017

JiangtianLi commented Aug 24, 2017

seanknox commented Aug 24, 2017

seanknox commented Aug 24, 2017

JiangtianLi left a comment

Choose a reason for hiding this comment

seanknox commented Aug 25, 2017

seanknox commented Aug 25, 2017

seanknox commented Aug 26, 2017 • edited Loading

JiangtianLi commented Aug 26, 2017

seanknox commented Aug 26, 2017

seanknox commented Sep 1, 2017

JiangtianLi Sep 1, 2017

Choose a reason for hiding this comment

seanknox Sep 1, 2017

Choose a reason for hiding this comment

JiangtianLi Sep 1, 2017

Choose a reason for hiding this comment

JiangtianLi Sep 1, 2017

Choose a reason for hiding this comment

seanknox Sep 1, 2017 • edited Loading

Choose a reason for hiding this comment

jackfrancis Sep 1, 2017

Choose a reason for hiding this comment

JiangtianLi Sep 1, 2017

Choose a reason for hiding this comment

seanknox commented Sep 1, 2017

jackfrancis commented Aug 24, 2017 •

edited by seanknox

Loading

seanknox commented Aug 26, 2017 •

edited

Loading

seanknox Sep 1, 2017 •

edited

Loading