Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Notes on 3rd party dependencies #1272

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Notes on 3rd party dependencies #1272

merged 2 commits into from
Aug 17, 2017

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Aug 16, 2017

What this PR does / why we need it: add docs on how we manage 3rd party dependencies in the project

Release note:

dependencies documentation

This change is Reviewable

@ghost ghost assigned jackfrancis Aug 16, 2017
@ghost ghost added the in progress label Aug 16, 2017
@ghost ghost assigned acs-bot Aug 16, 2017
@jackfrancis
Copy link
Member Author

@anhowe @seanknox @jchauncey FYI, a 1st draft on the language that describes how we intend to express a structured dependency management strategy

@seanknox
Copy link
Contributor

This is great. Worth mentioning that all dependencies need to be registered with Microsoft OSS to be cleared for use?

@@ -54,6 +54,14 @@ workflow for doing this is as follows:
5. When you are ready for us to review, push your branch to GitHub, and
then open a new pull request with us.

### Third Party Dependencies
Copy link
Contributor

@jchauncey jchauncey Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive added an issue about updating labels (#1277) so when people submit prs/issues that need dependency updates/additions we can track them.

@jchauncey
Copy link
Contributor

My only comment to this is I wonder if this should be some where more visible?

@jackfrancis
Copy link
Member Author

@seanknox I'm inclined to defer on how much info we publish about that. Who would be the best resource to determine how we want to say that?

@seanknox
Copy link
Contributor

@seanknox I'm inclined to defer on how much info we publish about that. Who would be the best resource to determine how we want to say that?

Fair enough. As long as there's a process we (ACS) follow to ensure dependencies are registered, that's what matters.

@jackfrancis jackfrancis merged commit 86cea02 into Azure:master Aug 17, 2017
@ghost ghost removed the in progress label Aug 17, 2017
@jackfrancis jackfrancis deleted the dependencies-docs branch August 17, 2017 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants