This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add pod subnet to non masquerade #1142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sylr, It will cover your contributions to all Microsoft-managed open source projects. |
|
Can one of the admins verify this patch? Say "@acs-bot test this please" to start tests. |
|
@sylr, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Signed-off-by: Sylvain Rabot <[email protected]>
sylr
force-pushed
the
non-masquerade-cidr
branch
from
c4309b8 to
3f20ea2
Compare
|
What is the status on this one? |
|
I am also having the same issue, would appreciate an update! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If this option is not provided the default used by kubelet is 10.0.0.0/8 (according to #425 (comment)).
In a Custom VNet context (VNet space which is not 10.0.0.8), we want to set this value to the subnet of the pods (kubeClusterCidr) otherwise Kubernetes will think that all traffic directed towards 10.0.0.0/8 from the pods is intended to stay within Kubernetes.
By setting the correct subnet all traffic which is outside kubeClusterCidr will be "masqueraded" and will be able to exit kubernetes and reach the intended resources in the Custom VNet.
Which issue this PR fixes: fixes #425
Special notes for your reviewer:
Release note:
This change is