This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
chore(coverage): add make coverage command
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
seanknox
force-pushed
the
chores/add-coverage
branch
2 times, most recently
from
46281ed to
83c9d85
Compare
seanknox
force-pushed
the
chores/add-coverage
branch
from
83c9d85 to
76293cb
Compare
|
Call me curious what does our coverage look like at the moment? |
|
@JackQuincy 38%. We've got our work cut out for us. https://coveralls.io/github/Azure/acs-engine |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: adds
make coverageto generate test coverage report, and optionally send coverage reports to coveralls.io.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1070Special notes for your reviewer:
Release note:
This change is