Enable k8s 1.7.2 release #1072

lachie83 · 2017-07-21T20:11:31Z

This change is

msftclas · 2017-07-21T20:11:35Z

@lachie83,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

acs-bot · 2017-07-21T20:12:08Z

Can one of the admins verify this patch? Say "@acs-bot test this please" to start tests.

seanknox · 2017-07-21T20:44:05Z

@acs-bot test this please

…eziser to 1.7

martell · 2017-07-24T14:38:22Z

@lachie83 is there a reason why the resizer was rolled back to 1.7 when 2.0 is used with 1.7.1?

Looking forward to seeing this merged because https://github.com/kubernetes/kubernetes/pull/46360/files
currently disks are very slow attaching and fail a lot in random ways :)

lachie83 · 2017-07-24T15:39:59Z

hey @martell. It seems it has caused a regression because some options have been removed in 2.0. I've currently opted to go back to 1.7 then we can raise another PR to go to 2.0 across the board later. #1075 How does that sound? I couldn't actually see any compelling reason to bounce this version as part of any of these PR. Do you know of one. Is there a changelog somewhere for the resizer?

martell · 2017-07-24T16:15:22Z

hey @lachie83 :)

hmm, the versioning for that contrib project is not immediately obvious.
I do not see any clear change logs also btw nor am I aware of any.
From looking through the commit logs though I see we can just remove the following 2 options.
--estimator=exponential and --threshold=5 the latter seems to be removed by the rbac PR.
Assuming we can get that merged it should be easy to just remove the former option.
Seems reasonable to revert 170 and 171 to 1.7 until we do this.

Are there other options where it is causing trouble for you?

lachie83 · 2017-07-24T21:03:38Z

That sounds good to me.

lachie83 · 2017-07-25T17:25:04Z

@acs-bot test this please

Remove toLower from storage tier name

JiangtianLi · 2017-07-26T20:02:05Z

@lachie83 @rjtsdl I think there will be merge conflict with your PRs. Please coordinate to resolve.

JiangtianLi · 2017-07-26T20:04:16Z

Also, do we need to add to tests for 1.7.2 (except Windows, which I will add)?

lachie83 · 2017-07-26T20:05:38Z

Also, do we need to add to tests for 1.7.2 (except Windows, which I will add)?

Nothing specific to this release

lachie83 · 2017-07-26T20:05:54Z

@lachie83 @rjtsdl I think there will be merge conflict with your PRs. Please coordinate to resolve.

I will rebase once this is approved

JiangtianLi · 2017-07-26T20:10:41Z

Jingtao's #1108 is not in yet.

JiangtianLi

LGTM

lachie83 · 2017-07-26T20:38:39Z

@acs-bot test this please

rjtsdl · 2017-07-26T21:34:07Z

Let's get this in first. I Will resolve on my. Lgtm. You can consider approved from me. Don't know How to hit approve button on phone :(

lachie83 · 2017-07-26T21:35:18Z

@rjtsdl @JiangtianLi how do I get CI running?

rjtsdl · 2017-07-26T21:38:03Z

1 remove in progress label
2 @acs-bot test this please

lachie83 · 2017-07-26T21:38:40Z

@acs-bot test this please

seanknox · 2017-07-27T02:14:33Z

@acs-bot test this please

seanknox · 2017-07-27T02:17:14Z

@rjtsdl @lachie83 no need to remove the "in progress" label—CI doesn't use it anymore. In fact, please do not do this as our backlog uses it.

seanknox · 2017-07-27T21:54:09Z

@lachie83 can you try deploying a k8s 1.5.7 cluster from your branch? e2e tests keep failing on v1.5.7 tests due to some error in the provisioning process:

{
  "id": "/subscriptions/xxx/resourceGroups/y-kubernetesversions-kubernetes1.5.7-centralus-1037-16-0",
  "location": "centralus",
  "managedBy": null,
  "name": "y-kubernetesversions-kubernetes1.5.7-centralus-1037-16-0",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": null
}
time="2017-07-27T02:43:02Z" level=info msg="Generating assets..." 
time="2017-07-27T02:43:12Z" level=debug msg="pki: PKI asset creation took 3.345644484s" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/apimodel.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/azuredeploy.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/azuredeploy.parameters.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.australiaeast.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.australiasoutheast.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.brazilsouth.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.canadacentral.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.canadaeast.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.centralindia.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.centralus.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.centraluseuap.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.chinaeast.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.chinanorth.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.eastasia.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.eastus.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.eastus2.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.eastus2euap.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.japaneast.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.japanwest.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.koreacentral.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.koreasouth.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.northcentralus.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.northeurope.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.southcentralus.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.southeastasia.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.southindia.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.uksouth.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.ukwest.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.westcentralus.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.westeurope.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.westindia.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.westus.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubeconfig/kubeconfig.westus2.json" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/ca.key" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/ca.crt" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/apiserver.key" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/apiserver.crt" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/client.key" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/client.crt" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubectlClient.key" 
time="2017-07-27T02:43:12Z" level=debug msg="output: wrote /gopath/src/github.com/Azure/acs-engine/_output/acse-2257273-centralus-1037-16-0/kubectlClient.crt" 
Error [deploy_template:y-kubernetesversions-kubernetes1.5.7-centralus-1037-16-0] exit status 1
Output: /usr/local/bin/kubectl
/usr/local/bin/az
ERROR: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details. {
  "status": "Failed",
  "error": {
    "code": "ResourceDeploymentFailure",
    "message": "The resource operation completed with terminal provisioning state 'Failed'.",
    "details": [
      {
        "code": "VMExtensionProvisioningError",
        "message": "VM has reported a failure when processing extension 'cse0'. Error message: \"Enable failed: failed to execute command: command terminated with exit status=127\"."
      }
    ]
  }
}

https://jenkins.azure-containers.io/job/acs-engine-pr/1037/artifact/_logs/y-kubernetesversions-kubernetes1.5.7-centralus-1037-16-0.log

lachie83 · 2017-07-27T22:06:07Z

@seanknox sure thing

lachie83 · 2017-07-27T22:36:58Z

@seanknox please retest.

lachie83 · 2017-07-27T23:57:12Z

@acs-bot test this please

* [API] use validate tag for vlab version as well (Azure#1096) * use validate tag for vlab version as well * move handleValidationErrors function into a common place * Added retries for apt-get install and systemctl enable commands for kubernetes custom script. (Azure#1104) * added retries to apt-get in runcmd for kubernetes cloudinit * Added retries for systemctl enable commands as part of kubernetes custom script. (Azure#853) * Change exit to different number. * Build Linux, Mac, and Windows binaries (Azure#1077) * chore(Makefile): improve bootstrap command * ref(Makefile): refactor `make build`, use go install * chore(release): support building windows, linux, macos binaries * ref(Makefile): change name order of bins (project-ver-platform-arch) * fix(ci): fix path of acs-engine binary * fix(Makefile): fix wrong argument in go install * added metrics for deployment and validation durations (Azure#1111) * added metrics for deployment and validation durations * fix(deploy): Change SP creation logging to debug (Azure#1121) * remove StorageProfile defaults in v20170701 (Azure#1119) * remove StorageProfile defaults in v20170701 * fix v20170701 test * remove comments * acs-engine test housekeeping (Azure#1125) - added label to resource group, to enable auto-removal in case of unexpected job termination (performed by another scheduled job) - set the default for metrics sending to false * add script to add admin to docker group (Azure#1113) * Enable k8s 1.7.2 release (Azure#1072) * Enable k8s 1.7.2 release * remove version specific pieces of the heapster deployment. Rollback reziser to 1.7 * rollback resizer to 1.7 * fixed typo in version * Add new storageclasses for managed disk types * add storagetier label to nodes * add newlines * Add error handling to getStorageAccountType function Remove toLower from storage tier name * fixed indentation * add StorageClass resources to 1.5 * remove version specific pieces of the heapster deployment. Rollback reziser to 1.7 (Azure#1076) * Removing the requirement for same vNet (Azure#850) As per Azure#272 - this is no longer necessary. * docs(large-clusters): add docs for building large k8s clusters (Azure#1001) * docs(large-clusters): add docs for building large k8s clusters * doc(large-clusters): mention 100 pod/node limit in k8s v1.7 * Obvious Makefile typo and documentation update (Azure#1126) * fix Makefile typo * fix documentation with new acs-engine path * Added minimal rbac setup for k8s. * Make heapster rolebinding. * Add kube-dns rolebindings. * Smaller fixes, * Conditionalize enabling of RBAC Add rbac cluster definition example Update kube addon manager to support clusterrolebinding creation Update kube-addon-manager to use service account Update API server with RBAC parameter Update Controller Manager to use separate accounts per controller Update heapster to support RBAC Update dashboard to support RBAC Add enableRbac field to ClusterConfig and add docs * remove service account from addon manager * Make heapster rolebinding. * Add kube-dns rolebindings. * Smaller fixes, * Conditionalize enabling of RBAC Add rbac cluster definition example Update kube addon manager to support clusterrolebinding creation Update kube-addon-manager to use service account Update API server with RBAC parameter Update Controller Manager to use separate accounts per controller Update heapster to support RBAC Update dashboard to support RBAC Add enableRbac field to ClusterConfig and add docs * remove service account from addon manager * update heapster deployment * Fix some merge conflicts. * update CR and CRB to support heapster nanny rather than use the bootstrapped CR * removed unrelated modifications to addons * Added test for certificate creation with and without organisation. * re-add resource limits and remove quotes * rebase master heapster updates, add 1.5 rbac apis * manifest updates * update addon-manager version across all releases, update kube-dns 1.5 * fixed dup field defs * remove templates.go * cleaned up more rebase dups

Enable k8s 1.7.2 release

dbf96df

msftclas added the cla-not-required label Jul 21, 2017

gabrtv added the in progress label Jul 21, 2017

lachie83 added 2 commits July 21, 2017 15:09

remove version specific pieces of the heapster deployment. Rollback r…

fd01a75

…eziser to 1.7

rollback resizer to 1.7

45bbc0d

lachie83 and others added 2 commits July 25, 2017 10:21

Merge branch 'master' into k8s-1.7.2

684f602

fixed typo in version

f297e91

lachie83 added 6 commits July 25, 2017 14:49

Add new storageclasses for managed disk types

a7bcf58

add storagetier label to nodes

3b3d37e

add newlines

6076520

Add error handling to getStorageAccountType function

441fa9e

Remove toLower from storage tier name

Add TestGetStorageAccountType

6174e6c

fixed indentation

9181d4c

JiangtianLi approved these changes Jul 26, 2017

View reviewed changes

rjtsdl approved these changes Jul 26, 2017

View reviewed changes

lachie83 removed the in progress label Jul 26, 2017

add StorageClass resources to 1.5

ed017e0

seanknox merged commit 0c0091b into Azure:master Jul 28, 2017

seanknox mentioned this pull request Jul 28, 2017

Release Kubernetes 1.7.2 - Windows #1074

Closed

lachie83 mentioned this pull request Aug 17, 2017

Managed Disks are not yet supported by k8s persistent volumes #849

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable k8s 1.7.2 release #1072

Enable k8s 1.7.2 release #1072

lachie83 commented Jul 21, 2017 •

edited

Loading

msftclas commented Jul 21, 2017

acs-bot commented Jul 21, 2017

seanknox commented Jul 21, 2017

martell commented Jul 24, 2017 •

edited

Loading

lachie83 commented Jul 24, 2017 •

edited

Loading

martell commented Jul 24, 2017 •

edited

Loading

lachie83 commented Jul 24, 2017

lachie83 commented Jul 25, 2017

JiangtianLi commented Jul 26, 2017

JiangtianLi commented Jul 26, 2017

lachie83 commented Jul 26, 2017

lachie83 commented Jul 26, 2017

JiangtianLi commented Jul 26, 2017

JiangtianLi left a comment

lachie83 commented Jul 26, 2017

rjtsdl commented Jul 26, 2017

lachie83 commented Jul 26, 2017

rjtsdl commented Jul 26, 2017

lachie83 commented Jul 26, 2017

seanknox commented Jul 27, 2017

seanknox commented Jul 27, 2017

seanknox commented Jul 27, 2017

lachie83 commented Jul 27, 2017

lachie83 commented Jul 27, 2017

lachie83 commented Jul 27, 2017

Enable k8s 1.7.2 release #1072

Enable k8s 1.7.2 release #1072

Conversation

lachie83 commented Jul 21, 2017 • edited Loading

msftclas commented Jul 21, 2017

acs-bot commented Jul 21, 2017

seanknox commented Jul 21, 2017

martell commented Jul 24, 2017 • edited Loading

lachie83 commented Jul 24, 2017 • edited Loading

martell commented Jul 24, 2017 • edited Loading

lachie83 commented Jul 24, 2017

lachie83 commented Jul 25, 2017

JiangtianLi commented Jul 26, 2017

JiangtianLi commented Jul 26, 2017

lachie83 commented Jul 26, 2017

lachie83 commented Jul 26, 2017

JiangtianLi commented Jul 26, 2017

JiangtianLi left a comment

Choose a reason for hiding this comment

lachie83 commented Jul 26, 2017

rjtsdl commented Jul 26, 2017

lachie83 commented Jul 26, 2017

rjtsdl commented Jul 26, 2017

lachie83 commented Jul 26, 2017

seanknox commented Jul 27, 2017

seanknox commented Jul 27, 2017

seanknox commented Jul 27, 2017

lachie83 commented Jul 27, 2017

lachie83 commented Jul 27, 2017

lachie83 commented Jul 27, 2017

lachie83 commented Jul 21, 2017 •

edited

Loading

martell commented Jul 24, 2017 •

edited

Loading

lachie83 commented Jul 24, 2017 •

edited

Loading

martell commented Jul 24, 2017 •

edited

Loading