Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

bumped addonmanager tag to be consistent with other releases #1064

Merged
merged 1 commit into from
Jul 20, 2017
Merged

bumped addonmanager tag to be consistent with other releases #1064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/acsengine/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ var KubeImages = map[api.OrchestratorVersion]map[string]string{
"addonresizer": "addon-resizer:2.0",
"heapster": "heapster:v1.4.0",
"dns": "k8s-dns-kube-dns-amd64:1.14.4",
"addonmanager": "kube-addon-manager-amd64:v6.1.2",
"addonmanager": "kube-addon-manager-amd64:v6.4-beta.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we are using a beta version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the version that currently supports using kubectl 1.6 which is required for creation of RBAC resource types using addon-manager . See this for the changelog --
https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/addon-manager/CHANGELOG.md#version-64-beta2--mon-june-12-2017-jeff-grafton-jgraftongooglecom. We used the 6.4 tag but which I thought would cover this beta since 6.4 hasn't actually been releases and the timestamp on 6.4 is much older than the 6.4-beta.2 -- https://gcr.io/v2/google_containers/kube-addon-manager/tags/list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we need 6.4 and it is still in beta. Is that correct? I guess this is okay, but just makes me kind of nervous to use beta versions.

"dnsmasq": "k8s-dns-dnsmasq-amd64:1.14.4",
"pause": "pause-amd64:3.0",
"windowszip": "v1.7.0intwinnat.zip",
Expand Down