acs-engine quick-create ...

[khenidak]

We have talked multiple times with regards to optimized creation process (cc: @jessfraz @jackfrancis @cpuguy83, @CecileRobertMichon ) - The current process is:

1. Lengthy : copy api-model, modify values, do acs-engine generate then deploy. Each step is prone to errors (spelling issues, copy/paste etc).
2. The current process is not optimized the best practices (turn on MSI, use premium disks etc).

Proposal:

1. Establish a well know golden api-model (as part of the binary). That golden model encompasses all the best practices that we learned and learning. The api-model will also be updated as part of the release as needed.

2. Create a new CLI command acs-engine quick-create --resource-group --location --master-count {n} --agentpool-count {n} --node-per-pool {n} --overrides [{key:val}] --output-directory {path} calling this command will:

3. Generate the needed api-model + ARM template

4. Create resource-group

5. Perform deployment

It is assumed that some of the advanced feature (such as BYO VNET) will not supported by quick-create

@cpuguy83 is willing to carry this forward.

comments/questions?

[cpuguy83]

Not sure how I feel about the --overrides flag. It's feels a bit too loosey-goosey.
What if it can generate a golden template that users can edit for overrides?

[khenidak]

I am game not to have overrides at all. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Brian Goff <[email protected]> Sent: Wednesday, June 27, 2018 1:18:20 PM To: Azure/acs-engine Cc: Khaled Henidak (Kal); Author Subject: Re: [Azure/acs-engine] acs-engine quick-create ... (#3378) Not sure how I feel about the --overrides flag. It's feels a bit too loosey-goosey. What if it can generate a golden template that users can edit for overrides? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Facs-engine%2Fissues%2F3378%23issuecomment-400815180&data=02%7C01%7C%7Cc7d79659d9e14721c27208d5dc6b20b7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636657275021188199&sdata=JW%2BlDbzBhmYaT%2BJ%2FiqwCOliYeCo9rfBGCha2dOSUEgU%3D&reserved=0>, or mute the thread<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKMDQxVllcyy1CxqkHQdCkqPajjMtRnwks5uA-iMgaJpZM4U6TDw&data=02%7C01%7C%7Cc7d79659d9e14721c27208d5dc6b20b7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636657275021188199&sdata=3WaCnHmrGALY%2Bgmhb6d%2BmGOVjlBdsNnTlfzpC%2Fz0x%2BA%3D&reserved=0>.

[cpuguy83]

How about acs-engine deploy --with-builtin-model --builtin-model-name v0 where, for now, the new flags are mutually exclusive with --api-model and the version flag can be used to deploy a specific version but the default is the latest version.

Alternatively --api-model could default to the value of builtin (thereby also making it a reserved word). This would still include the model name flag as well.

[serbrech]

Note that we have the --set flag implemented by @jcorioland that might solve your --override idea

merged PR : #2787
--set flag docs

[cpuguy83]

Another thought here:

$ acs-engine create [basic opts to configure model] > model.json
<edit and/or commit model>
$ acs-engine deploy --api-model model.json

As well as a simple

$ acs-engine create [basic opts to configure model] --deploy

These could also be flipped to deploy by default and have a flag to output the model that can be consumed by the deploy subcommand.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. Note that acs-engine is deprecated--see https://github.com/Azure/aks-engine instead.