This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Windows profile validation missing when there is at least one windows agentpool #2788
Assignees
Labels
cse-sync-week
Triage for issues that would be good for CSE sync week, April 24-27th 2018
Comments
CecileRobertMichon
added
the
cse-sync-week
JamesEarle
pushed a commit
to JamesEarle/acs-engine
that referenced
this issue
Apr 27, 2018
…rror in generation Azure#2788
CecileRobertMichon
pushed a commit
that referenced
this issue
May 17, 2018
* adding windowsprofile validation checking, will handle 'hassecrets' error in generation #2788 * adding null check for windows profile before validation * adding ostype check and validation * check for empty string not nil * change string to ostype in validatePoolOSType * removing redundant windows check, using constants for validation * empty string as valid option * syntax fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Repro:
acs-engine generate --api-model myapimodelwheremyapimodelhas at least one agentpoolprofile but nowindowsProfileWe should validate that windowsProfile != nil when there is a windows agentPool and return an error along the lines of "windowsProfile is required when the cluster definition contains Windows agent pool(s)".
The text was updated successfully, but these errors were encountered: