Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

docs: add standalone Code of Conduct doc where GH can see it #246

Merged
merged 2 commits into from
Jun 22, 2019

Conversation

mboersma
Copy link
Member

Reason for Change:
Adds the Microsoft Open Source Code of Conduct as a standalone document in the project root, as expected by GitHub community standards.

Issue Fixed:
None, but see also Azure/aks-engine#510

Notes for Reviewers:

@kkmsft
Copy link
Contributor

kkmsft commented Jun 17, 2019

@mboersma - is there a way for us to add a link to this and place that link as separate file as requirement ?

@kkmsft
Copy link
Contributor

kkmsft commented Jun 17, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mboersma
Copy link
Member Author

@kkmsft the trick is that Microsoft requires us to have the final paragraph of the README link to our online Code of Conduct, but GitHub wants to see a standalone Markdown document.

So the requirements don't sync up perfectly, but I'll add a link in the README to the local version as well.

@mboersma
Copy link
Member Author

Or did you mean having CODE_OF_CONDUCT.md just contain a link to the online version? I thought of that and it would ensure we don't repeat ourselves. But I'm guessing that GitHub's intent is to have the project be self-documenting so that a tarball download contained this info.

The simplest solution seemed to be to allow ourselves to repeat the document, but let me know what you'd prefer.

@kkmsft
Copy link
Contributor

kkmsft commented Jun 21, 2019

@mboersma - First Thank you :-) for looking at this and providing the context. I am leaning towards the first choice you mention above - CODE_OF_CONDUCT.md just contain a link to the online version. Would prefer that it's a consistent pointer and not repeat ourselves.

@kkmsft kkmsft merged commit ce198a7 into Azure:master Jun 22, 2019
@kkmsft
Copy link
Contributor

kkmsft commented Jun 22, 2019

Thank you, @mboersma

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants