suppress systemd errors in e2e tests #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
narrieta
reviewed
Jan 7, 2025
tests_e2e/tests/lib/agent_log.py
Outdated
| @@ -454,7 +476,7 @@ def matches_ignore_rule(record: AgentLogRecord, ignore_rules: List[Dict[str, Any | |||
| """ | |||
| Returns True if the given 'record' matches any of the 'ignore_rules' | |||
| """ | |||
| return any(re.search(rule['message'], record.message) is not None and ('if' not in rule or rule['if'](record)) for rule in ignore_rules) | |||
| return any(re.search(rule['message'], record.message, flags=re.DOTALL) is not None and ('if' not in rule or rule['if'](record)) for rule in ignore_rules) | |||
There was a problem hiding this comment.
we should not do this for all rules (or if we do, we need to go back and review very carefully all the existing rules and associated messages).
you can do this exlplicitly at the regex level, as in
'message': r"(?s)name=Microsoft.GuestConfiguration.ConfigurationforLinux.*op=Install.*Unexpected Linux distribution"
regex starts with (?s)
nagworld9
force-pushed
the
suppress-systemd-errors
branch
from
f263ad6 to
60f5f46
Compare
narrieta
approved these changes
Jan 7, 2025
maddieford
approved these changes
Jan 7, 2025
nagworld9
added a commit
to nagworld9/WALinuxAgent
that referenced
this pull request
Jan 7, 2025
* ingonre systemd errors * addressing comment (cherry picked from commit 844c0a6)
nagworld9
added a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
suppress systemd errors in e2e tests
Issue #
PR information
developbranch.Quality of Code and Contribution Guidelines