Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove secret and use cert for aad app in e2e pipeline (#3116) #3125

Merged
merged 1 commit into from
May 10, 2024

Conversation

narrieta
Copy link
Member

  • remove secret and use cert

  • address comment

(cherry picked from commit 6e5cde0)

* remove secret and use cert

* address comment

(cherry picked from commit 6e5cde0)
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (hotfix-2.11.1.0@892fdb8). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             hotfix-2.11.1.0    #3125   +/-   ##
==================================================
  Coverage                   ?   71.68%           
==================================================
  Files                      ?      109           
  Lines                      ?    16405           
  Branches                   ?     2344           
==================================================
  Hits                       ?    11760           
  Misses                     ?     4098           
  Partials                   ?      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@narrieta narrieta merged commit 79414a7 into Azure:hotfix-2.11.1.0 May 10, 2024
8 of 9 checks passed
@narrieta narrieta deleted the cp branch May 10, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants