Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for extension workflow #2843
Add tests for extension workflow #2843
Changes from 110 commits
da72c37
59dbd22
633a826
14a743f
54ea0f3
e79c4c5
498b612
1e269f4
7b49e76
0a426cc
17fbf6a
995cbb9
eaadc83
fb03e07
6a8e0d6
8e62c05
9999aef
9d6cb62
e7c010c
193662b
bf7fc04
f7f7a54
5aad0ac
acd4ae5
1fc51a1
7b43af7
11b73e0
d8c1d21
6cf987a
4b56360
bda8708
2ba6238
79cae43
40f98a6
8aef67d
d4c9a99
2f3731c
788584c
8de7846
0a4d328
83d3c8e
2788d53
4f8a31b
a329a46
d440058
dcde7ea
b8c2605
ec7bed6
cde74ad
4b44b7e
104a623
1f4bd31
a318adc
81eca75
976cbb4
9637ea3
df94a37
1950555
ed51360
5604d3c
b4951c8
54184e7
7dac115
84946b3
e5dcd98
f97197e
f46afae
8ff742d
6d388f8
b929556
b0d1e22
d3d71f9
deef228
fe2f2c2
482f3fe
8bda6b5
75cf5a0
2b0ed08
48949e0
3ba0f05
c14125a
0380130
ef9291a
30a1740
dbecb19
8343df1
5dce3dd
8c5bd6d
d3c06b4
c34aa27
b9c9ada
7f208f9
5466804
8e6a672
2a88fd0
fb49cfc
dd46d51
947134b
0d16066
356f9a9
d081330
bdd4934
2e0303e
cf7d6ca
2613d40
2a1c260
bc842b1
746689d
9db7ce4
9735035
ed6e900
ebd1e03
b3dabdb
0abeec2
59c9456
627be4a
9f9ecea
666fac5
e643fc1
ab487b7
96f9a3e
30f9f6b
08f473b
f845bd5
5aeee72
60b04d4
eef24e8
5b48168
6adbf50
17764c1
549b8ef
56e0edb
86a0212
2aa1cc3
40a25f4
bf4cf31
9010e01
22a8b81
dbee33e
40b112c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should run on all endorsed distros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now I have it matching the config from the dcr repo: https://msazure.visualstudio.com/One/_git/Compute-Runtime-Tux-Pipeline?path=/dungeon_crawler/scenarios/agent-ext-workflow/config.json
The DCR Test Extension has issues when installed/enabled on other distros. For example, I tried to run this test workflow on debian_9 and the extension fails to be installed:
If we wanted to run on all endorsed distros, we'd need to do some work to improve the test extension. I think we should include this as part of the work to implement the extension in Rust, and limit this workflow to these images for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's sync offline... we may need to fix this even before thinking of rewriting the extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created task to circle back on this after I migrate remaining scenarios: https://dev.azure.com/msazure/One/_workitems/edit/24442982
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this readme directly from DCR because it contains a lot of useful information about the GuestAgentDcrTestExtension.
Let me know if I should add this information as comments to the test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme is fine, though a summary in the suite file would be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a publishing pipeline for the test extension? could you create one and publish it to all regions? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have CAPS pipeline already and deployed few other regions too. I would restrict to few regions where we create vms and deploying to all of no use.
https://msazure.visualstudio.com/One/_releaseProgress?_a=release-pipeline-progress&releaseId=7405435
https://msazure.visualstudio.com/One/_git/Compute-ART-LinuxExtensions?path=/src/EV2/GATestExtension_ExtensionInfo.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait on this until we've implemented the test extension in Rust?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagworld9 those links are for a different test extension. The type name for that extension is GATestExtGo, but the type name for the extension we use in this test suite is GuestAgentDcrTest