-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a first version to allow for custom removal scripts & retry #431
Conversation
…moval script path param
Unit Test Results 1 files ± 0 1 suites ±0 21s ⏱️ +5s Results for commit 96e99b7. ± Comparison against base commit 6cd1d7f. This pull request removes 4 and adds 31 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Also:
- Missing docs on some PowerShell functions.
- Missing subscription and managementGroup scope for removal (if im not mistaken). (Guess this is for the next version.
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments seem to be solved. Green pipelines which are also a good indicator of working solution. Lets see if this solves our faulty workflows and removal steps! Approved.
Change
Tested multiple times with
Type of Change
Please delete options that are not relevant.
Checklist