Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up network modules & added output descriptions #420

Merged
merged 3 commits into from
Nov 6, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 5, 2021

Change

  • Cleaned up network modules
    • Convert json(null) into null
    • Removed excess brackets
  • added output descriptions

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr linked an issue Nov 5, 2021 that may be closed by this pull request
@AlexanderSehr AlexanderSehr added this to the v 0.3 milestone Nov 5, 2021
@AlexanderSehr AlexanderSehr added [cat] modules category: modules enhancement New feature or request labels Nov 5, 2021
@AlexanderSehr AlexanderSehr self-assigned this Nov 5, 2021
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 5, 2021 19:47
@MariusStorhaug
Copy link
Contributor

I just unlinked the issue as the issue is for all modules. Linking it and completing this PR would close the issue. Think we want to leave it open until all json('null) are swapped out with null.

@MariusStorhaug
Copy link
Contributor

MariusStorhaug commented Nov 6, 2021

Another issue this is addressing (but should not automatically close) is: #238

Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with these changes. Approved.

@AlexanderSehr AlexanderSehr merged commit 31ab2d8 into main Nov 6, 2021
@MariusStorhaug MariusStorhaug deleted the users/alsehr/jsonNullNetwork branch November 6, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants