Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes] Updated remaining PE references that got not passed down to the actual module #4119

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[Fixes] Updated remaining PE references that got not passed down to the actual module #4119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/app-configuration/configuration-store/.test/pe/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ module testDeployment '../../main.bicep' = {
enablePurgeProtection: false
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'configurationStores'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Expand Down
16 changes: 6 additions & 10 deletions modules/app-configuration/configuration-store/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,11 +411,9 @@ module configurationStore 'br:bicep/modules/app-configuration.configuration-stor
enablePurgeProtection: false
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'configurationStores'
subnetResourceId: '<subnetResourceId>'
tags: {
Expand Down Expand Up @@ -467,11 +465,9 @@ module configurationStore 'br:bicep/modules/app-configuration.configuration-stor
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "configurationStores",
"subnetResourceId": "<subnetResourceId>",
"tags": {
Expand Down
10 changes: 5 additions & 5 deletions modules/cache/redis-enterprise/.test/common/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ module testDeployment '../../main.bicep' = {
zoneRedundant: true
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'redisEnterprise'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Expand Down
16 changes: 6 additions & 10 deletions modules/cache/redis-enterprise/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,9 @@ module redisEnterprise 'br:bicep/modules/cache.redis-enterprise:1.0.0' = {
minimumTlsVersion: '1.2'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'redisEnterprise'
subnetResourceId: '<subnetResourceId>'
tags: {
Expand Down Expand Up @@ -180,11 +178,9 @@ module redisEnterprise 'br:bicep/modules/cache.redis-enterprise:1.0.0' = {
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "redisEnterprise",
"subnetResourceId": "<subnetResourceId>",
"tags": {
Expand Down
10 changes: 5 additions & 5 deletions modules/cache/redis/.test/common/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ module testDeployment '../../main.bicep' = {
zones: [ 1, 2 ]
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'redisCache'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Expand Down
16 changes: 6 additions & 10 deletions modules/cache/redis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,9 @@ module redis 'br:bicep/modules/cache.redis:1.0.0' = {
minimumTlsVersion: '1.2'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'redisCache'
subnetResourceId: '<subnetResourceId>'
tags: {
Expand Down Expand Up @@ -143,11 +141,9 @@ module redis 'br:bicep/modules/cache.redis:1.0.0' = {
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "redisCache",
"subnetResourceId": "<subnetResourceId>",
"tags": {
Expand Down
10 changes: 5 additions & 5 deletions modules/data-factory/factory/.test/common/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,11 @@ module testDeployment '../../main.bicep' = {
managedVirtualNetworkName: 'default'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'dataFactory'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Expand Down
16 changes: 6 additions & 10 deletions modules/data-factory/factory/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,9 @@ module factory 'br:bicep/modules/data-factory.factory:1.0.0' = {
managedVirtualNetworkName: 'default'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'dataFactory'
subnetResourceId: '<subnetResourceId>'
tags: {
Expand Down Expand Up @@ -223,11 +221,9 @@ module factory 'br:bicep/modules/data-factory.factory:1.0.0' = {
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "dataFactory",
"subnetResourceId": "<subnetResourceId>",
"tags": {
Expand Down
10 changes: 5 additions & 5 deletions modules/databricks/workspace/.test/common/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ module testDeployment '../../main.bicep' = {
customVirtualNetworkResourceId: nestedDependencies.outputs.virtualNetworkResourceId
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'databricks_ui_api'
subnetResourceId: nestedDependencies.outputs.defaultSubnetResourceId
tags: {
Expand Down
16 changes: 6 additions & 10 deletions modules/databricks/workspace/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,9 @@ module workspace 'br:bicep/modules/databricks.workspace:1.0.0' = {
prepareEncryption: true
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'databricks_ui_api'
subnetResourceId: '<subnetResourceId>'
tags: {
Expand Down Expand Up @@ -212,11 +210,9 @@ module workspace 'br:bicep/modules/databricks.workspace:1.0.0' = {
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "databricks_ui_api",
"subnetResourceId": "<subnetResourceId>",
"tags": {
Expand Down
10 changes: 5 additions & 5 deletions modules/digital-twins/digital-twins-instance/.test/common/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ module testDeployment '../../main.bicep' = {
lock: 'CanNotDelete'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'API'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
}
Expand Down
16 changes: 6 additions & 10 deletions modules/digital-twins/digital-twins-instance/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,9 @@ module digitalTwinsInstance 'br:bicep/modules/digital-twins.digital-twins-instan
lock: 'CanNotDelete'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'API'
subnetResourceId: '<subnetResourceId>'
}
Expand Down Expand Up @@ -156,11 +154,9 @@ module digitalTwinsInstance 'br:bicep/modules/digital-twins.digital-twins-instan
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "API",
"subnetResourceId": "<subnetResourceId>"
}
Expand Down
10 changes: 5 additions & 5 deletions modules/document-db/database-account/.test/sqldb/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ module testDeployment '../../main.bicep' = {
location: location
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'Sql'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Expand Down
16 changes: 6 additions & 10 deletions modules/document-db/database-account/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,11 +926,9 @@ module databaseAccount 'br:bicep/modules/document-db.database-account:1.0.0' = {
location: '<location>'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'Sql'
subnetResourceId: '<subnetResourceId>'
tags: {
Expand Down Expand Up @@ -1089,11 +1087,9 @@ module databaseAccount 'br:bicep/modules/document-db.database-account:1.0.0' = {
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "Sql",
"subnetResourceId": "<subnetResourceId>",
"tags": {
Expand Down
10 changes: 5 additions & 5 deletions modules/insights/private-link-scope/.test/common/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@ module testDeployment '../../main.bicep' = {
]
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'azuremonitor'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Expand Down
16 changes: 6 additions & 10 deletions modules/insights/private-link-scope/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,9 @@ This instance deploys the module with most of its features enabled.
enableDefaultTelemetry: '<enableDefaultTelemetry>'
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
'<privateDNSZoneResourceId>'
]
}
privateDnsZoneResourceIds: [
'<privateDNSZoneResourceId>'
]
service: 'azuremonitor'
subnetResourceId: '<subnetResourceId>'
tags: {
Expand Down Expand Up @@ -111,11 +109,9 @@ This instance deploys the module with most of its features enabled.
"privateEndpoints": {
"value": [
{
"privateDnsZoneGroup": {
"privateDNSResourceIds": [
"<privateDNSZoneResourceId>"
]
},
"privateDnsZoneResourceIds": [
"<privateDNSZoneResourceId>"
],
"service": "azuremonitor",
"subnetResourceId": "<subnetResourceId>",
"tags": {
Expand Down
10 changes: 5 additions & 5 deletions modules/key-vault/vault/.test/common/main.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,11 @@ module testDeployment '../../main.bicep' = {
}
privateEndpoints: [
{
privateDnsZoneGroup: {
privateDNSResourceIds: [
nestedDependencies.outputs.privateDNSZoneResourceId
]
}
privateDnsZoneResourceIds: [

nestedDependencies.outputs.privateDNSZoneResourceId

]
service: 'vault'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Expand Down
Loading
Loading