Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pipelines to be triggered if PR is merged to main #198

Merged
merged 3 commits into from
Oct 22, 2021
Merged

update pipelines to be triggered if PR is merged to main #198

merged 3 commits into from
Oct 22, 2021

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Oct 15, 2021

Change

Feel free to remove this sample text

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan enabled auto-merge (squash) October 15, 2021 16:54
eriqua
eriqua previously requested changes Oct 17, 2021
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ms.compute\virtualmanchines
  • ms.containerregistry\registries
  • ms.datafactory\factories
  • ms.eventhub\namespaces
  • ms.eventhub\namespacesResources\eventhubs
  • ms.management\managementGroups

still need reference to deploy.json as correspondent templates have not been moved to bicep yet

@MariusStorhaug
Copy link
Contributor

MariusStorhaug commented Oct 21, 2021 •
edited
Loading

NOTE! This PR will be reviewed and approved when the last modules are converted and merged.

@rahalan rahalan added this to the MVP milestone Oct 21, 2021
@rahalan rahalan linked an issue Oct 21, 2021 that may be closed by this pull request
Pipeline: Add automatic PR triggers (change on main) #228
Closed
@eriqua eriqua mentioned this pull request Oct 21, 2021
Merged
10 tasks
@rahalan rahalan requested a review from eriqua October 22, 2021 07:48
@rahalan rahalan merged commit 6ca234c into main Oct 22, 2021
@rahalan rahalan deleted the rahalan/AddPipelineTrigger branch October 22, 2021 08:24
@AlexanderSehr AlexanderSehr restored the rahalan/AddPipelineTrigger branch October 22, 2021 08:29
@AlexanderSehr AlexanderSehr deleted the rahalan/AddPipelineTrigger branch October 22, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@MariusStorhaug MariusStorhaug Awaiting requested review from MariusStorhaug

@eriqua eriqua Awaiting requested review from eriqua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Pipeline: Add automatic PR triggers (change on main)
4 participants
@rahalan @MariusStorhaug @AlexanderSehr @eriqua