feat(Templates): Support auto selecting template #6498
Conversation
libs/designer/src/lib/ui/panel/templatePanel/createWorkflowPanel/createWorkflowPanel.tsx
Show resolved
Hide resolved
| const DataProviderInner = ({ | ||
| customTemplates, | ||
| isConsumption, | ||
| existingWorkflowName, | ||
| viewTemplate, | ||
| children, | ||
| }: TemplatesDataProviderProps) => { |
There was a problem hiding this comment.
Why would we be loading all templates data when the ask from portal blade is to only open one single template? This is unnecessarily going to increase the panel load time.. that is why I was saying why do you want to lock the template
There was a problem hiding this comment.
They are looking for the least amount of code change for this purpose + the background of the template list view.....
I understand that we discussed about the concern of locking the template, but we had multiple meetings involving Divya where she agreed to the use case of this having to be the case..
@tonytang-microsoft-com would you have thoughts on this?
There was a problem hiding this comment.
Yes, this would be the least we could do to align with the current template experience. If we load only one template, then the UX will only have 1 template shown in the background, which looks different. I don't think this is a blocker and we could optimize the performance later if needed IMHO.
libs/designer/src/lib/ui/panel/templatePanel/createWorkflowPanel/tabs/basicsTab.tsx
Show resolved
Hide resolved
| @@ -214,6 +215,6 @@ export const reviewCreateTab = ( | |||
| } | |||
| } | |||
| }, | |||
| secondaryButtonDisabled: isCreating, | |||
| secondaryButtonDisabled: isCreating || (!previousTabId && isTemplateNameLocked), | |||
There was a problem hiding this comment.
Why do we have this logic in all secondary buttons related to template locked? in reviewCreateTab previousTabId is always true right?
There was a problem hiding this comment.
previousTabId shouldn't be present in case of consumption template with no connections/parameters
Type of Change
New Behavior
Add support to auto selecting template. When this new parameter is set, the template designer will automatically select the template as if user clicked the template and create.
Impact of Change
This is additive change so it's fully back compatible
built on top of #6485 with additional changes
Test Plan
Tested locally and added CIT
Screenshots or Videos (if applicable)