Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(designer): Add unit tests for graph container node #6415

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Jan 16, 2025

This pull request introduces new tests for the GraphContainer and GraphContainerNode components, enhancing the test coverage and ensuring better reliability. The changes include adding snapshot tests and various unit tests to verify different states and props of these components.

  • Added unit tests to verify the rendering of GraphContainer with different props such as selected and active.

  • Added snapshot tests to capture the rendered output of GraphContainer under various conditions.

  • Added comprehensive unit tests to verify the rendering of GraphContainerNode including scenarios like monitoring view, node size, and presence of DropZone.

  • Added snapshot tests to capture the rendered output of GraphContainerNode under various conditions.

Screenshots

Screenshot 2025-01-16 at 12 27 30 PM Screenshot 2025-01-16 at 12 28 08 PM

@ccastrotrejo ccastrotrejo requested a review from Copilot January 16, 2025 20:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

Files not reviewed (2)
  • libs/designer-ui/src/lib/card/graphContainer/test/snapshots/graphContainer.spec.tsx.snap: Language not supported
  • libs/designer/src/lib/ui/CustomNodes/test/snapshots/GraphContainerNode.spec.tsx.snap: Language not supported

Copy link
Contributor

@rllyy97 rllyy97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the typos are fixed

@ccastrotrejo ccastrotrejo enabled auto-merge (squash) January 16, 2025 21:44
@ccastrotrejo ccastrotrejo merged commit 98271a8 into main Jan 16, 2025
12 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/unitTestForGraphContainer branch January 16, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants