Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): Make Dropdown/Combobox options always have unique keys #6318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Eric-B-Wu
Copy link
Contributor

If combobox or dropdown options had non-unique display names (which we were stringifying to use as keys if there were no preset keys), it would cause an issue where there would be options matched to the same key. This makes it so even though users may click a certain dropdown option, it would result in the first option being found which would have a different value. This PR ensures that we always have a unique key to prevent this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant