Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(designer): Migrate delete node modal to fluent v9 #6242

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Dec 10, 2024

This pull request includes several changes to improve the user interface and functionality of modal dialogs and card components, as well as adding new tests. The most important changes include updating the DeleteNodeModal component to use the Dialog component from @fluentui/react-components, adding a focus restoration feature to card components, and introducing new tests for the DeleteNodeModal.

  • Updated to use Dialog and related components from @fluentui/react-components, added loading state messages, and implemented a callback for closing the dialog.
  • Added new tests for DeleteNodeModal to verify its behavior and ensure proper rendering of titles, body messages, and spinner states.
  • Added snapshot tests for DeleteNodeModal to ensure consistent rendering.
  • Removed unnecessary styles related to the old modal implementation.
  • Imported and used useRestoreFocusTarget to add focus restoration attributes to the Card component.
  • Imported and used useRestoreFocusTarget to add focus restoration attributes to the ScopeCard component.

Fixes #5273

Screenshots

Old version

Screenshot 2024-12-10 at 3 50 41 PM

New version

Screenshot 2024-12-10 at 3 50 24 PM

@ccastrotrejo ccastrotrejo requested a review from Copilot December 10, 2024 20:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 10 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • Localize/lang/strings.json: Language not supported
  • libs/designer-ui/src/lib/modals/test/snapshots/DeleteNodeModal.spec.tsx.snap: Language not supported
  • libs/designer-ui/src/lib/modals/styles.less: Language not supported
@ccastrotrejo ccastrotrejo changed the title fix(designer): Migrate node delete modal to fluent v9 feat(designer): Migrate delete node modal to fluent v9 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard focus doesn't retain back to the "More actions" control by invoking the "Cancel" button.
1 participant