fix(designer): Fixing Implicit For Each within Copy-Paste Scope #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takyyon
reviewed
Dec 9, 2024
| @@ -465,7 +466,7 @@ const initializeOutputTokensForOperations = ( | |||
| nodesWithData[operationId]?.settings | |||
| ) | |||
| ); | |||
| } catch (e) { | |||
| } catch { | |||
There was a problem hiding this comment.
we had changed our tsconfigs recently so that any unused variables error, this code I didn't change, but wanted to pass our commit
There was a problem hiding this comment.
Yeah that's totally okay but I meant we should be logging the exception/error here. Will help us debug in cases where it fails
ccastrotrejo
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6126
We require the actionName gotten from updateTokenMetadata to be used in updateScopePasteTokenMetadata