Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): Remove azure identity and restrict hybrid for public cloud #6215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ccastrotrejo
Copy link
Contributor

This pull request includes several changes to the vs-code-designer application, primarily focusing on updating dependencies and refactoring the LogicAppResolver class to use existing credentials from the subscription context.

Dependency updates:

  • Removed the @azure/identity dependency.

  • Updated the LogicAppResolver class to use subContext.credentials instead of creating a new DefaultAzureCredential instance.

  • Added a conditional check to only push promiseHybridLogicApp to the resolver promises if the resourceManagerEndpointUrl is 'https://management.azure.com/'.

Fixes #6149

@ccastrotrejo ccastrotrejo requested a review from Copilot December 5, 2024 17:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • apps/vs-code-designer/package.json: Language not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnvrionmentCredential Error in VS code with logic apps only
1 participant