Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Show local time and UTC in overview #4855

Merged
merged 5 commits into from
May 17, 2024

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented May 16, 2024

This pull request primarily involves changes to the localization and UI components in the codebase. The most significant changes include the addition of new localization strings, refactoring of UI components to use different libraries and components, and the addition of a feature to toggle between local and UTC time in the run history.

  • Added new localization strings for "Column header text for local time" and "Local time". These strings will be used to display local time in the UI.

  • Refactored the OverviewCommandBar component to use Button, Toolbar from @fluentui/react-components instead of CommandBar from @fluentui/react. Also, replaced the iconProps and name properties with icon and title respectively.

  • Added a feature to toggle between local and UTC time in the run history. This involved adding a new state variable useUTC, modifying the RunHistoryColumnKeys.START_TIME column to display the time in either local or UTC format based on useUTC, and changing the onRenderItemColumn function to format the start time accordingly.

Screen.Recording.2024-05-16.at.9.13.29.AM.mov

Copy link

Code Coverage Report

Code Coverage

Package Base Coverage New Coverage Difference
lib.overview 🟠 59.02% 🟠 61.19% 🟢 2.17%
Overall Coverage 🟢 21.05% 🟢 25.47% 🟢 4.42%

Minimum allowed coverage is 0%, this run produced 25.47%

@ccastrotrejo ccastrotrejo merged commit 3cc8511 into main May 17, 2024
12 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/udpateTimeVscode branch May 17, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants