Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent clock for Timestamp property #2035

Closed
marcschier opened this issue Aug 24, 2023 · 0 comments
Closed

Inconsistent clock for Timestamp property #2035

marcschier opened this issue Aug 24, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@marcschier
Copy link
Collaborator

Timestamp property in each data set message is the PublishTime, except when the notification is generated, e.g., cyclic read or heartbeat, or key frames. Then it is DateTime.UtcNow. It should be of the same clock, so it is comparable.

A command line option should be added to switch between sending wall clock of OPC Publisher or using publish time (where available). If no publish time is available, no timestamp property should be part of the message (to have consistency here as well). Proposal --MessageTimestamp=PublishTime --MessageTimestamp=CurrentTimeUtc. This will enable us to add other timestamping options in the future. (e.g., local time, or mixed option like today, or maxSourceTimestamp, etc.)

@marcschier marcschier self-assigned this Aug 24, 2023
@marcschier marcschier added this to the 2.9.1 milestone Aug 24, 2023
@marcschier marcschier added the bug Something isn't working label Aug 24, 2023
@marcschier marcschier assigned marcschier and unassigned marcschier Aug 24, 2023
marcschier added a commit that referenced this issue Aug 24, 2023
marcschier added a commit that referenced this issue Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant