Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal test update #1755

Merged
merged 23 commits into from
Sep 27, 2024
Merged

Portal test update #1755

merged 23 commits into from
Sep 27, 2024

Conversation

Springstone
Copy link
Member

Overview/Summary

This pull request includes several updates to the test workflow configuration, parameter files, and label definitions. The primary changes involve the addition of conditional steps in the GitHub Actions workflow, removal of a parameter from a JSON configuration file, and the introduction of new labels for different test scenarios.

Workflow Configuration Updates:

  • Conditional Steps for Test Labels: Added steps to check if specific test labels are set and conditionally run corresponding test configurations in the .github/workflows/test-portal.yml file. (.github/workflows/test-portal.yml)

Parameter File Updates:

  • Removal of AKS Policy Parameter: Removed the enableAksPolicy parameter from the eslzArm/eslzArm.test.param.json file. (eslzArm/eslzArm.test.param.json)

Label Definitions:

  • New Test Labels: Added new labels for different test scenarios (Test: Standard, Test: Hub & Spoke, Test: VWAN) in the utils/github/alz-repo-standard-labels.csv file. (utils/github/alz-repo-standard-labels.csv)

@Springstone Springstone marked this pull request as ready for review September 9, 2024 13:18
@Springstone Springstone requested a review from a team as a code owner September 9, 2024 13:18
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 9efd2e4 into Azure:main Sep 27, 2024
4 checks passed
@Springstone Springstone deleted the PortalTestUpdate branch September 27, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants