Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES Portal Accelerator - Creates privatelink.datafactory.azure.com (wrong) #944

Closed
omgitsjocke opened this issue Apr 5, 2022 · 1 comment · Fixed by #947
Closed

ES Portal Accelerator - Creates privatelink.datafactory.azure.com (wrong) #944

omgitsjocke opened this issue Apr 5, 2022 · 1 comment · Fixed by #947
Assignees
@jtracey93
Labels
bug Something isn't working engineering engineering work Status: Fixed

Comments

@omgitsjocke
Copy link

Hi,

During ES portal accelerator deployment (adventureworks) we decided to have private link domains provisioned.
Now we have discovered that privatelink.datafactory.azure.com was created, it's supposed to be privatelink.datafactory.azure.net according to documentation.

image

Documentation states:

Azure Data Factory (Microsoft.DataFactory/factories) / dataFactory privatelink.datafactory.azure.net datafactory.azure.net

Verified in Azure by checking domain used for creating a Private Endpoint for ADF:
image

We did the deployment at 15/3 in case it's already fixed, could not find any open nor closed issues on this.
@omgitsjocke omgitsjocke added the bug Something isn't working label Apr 5, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 5, 2022
@jtracey93 jtracey93 self-assigned this Apr 5, 2022
@jtracey93
Copy link
Collaborator

Thanks for raising this @omgitsjocke 👍

We will review all the Private DNS Zones are correct as per the docs https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-dns#azure-services-dns-zone-configuration and get this updated ASAP 👍

Thanks

Jack

@jtracey93 jtracey93 added engineering engineering work and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 5, 2022
@jtracey93 jtracey93 mentioned this issue Apr 6, 2022
Merged
6 tasks
jtracey93 added a commit that referenced this issue Apr 6, 2022
@jtracey93
Update Private Link/Endpoint Private DNS Zones (Fixing #944) & Doc Up…
ba7eba4 
…dates (#947)

* update private dns zones

* update ASR dns zone for FF and MC

* Docs updates
@ghost ghost added the Status: Fixed label Apr 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jtracey93 jtracey93

Labels
bug Something isn't working engineering engineering work Status: Fixed
Projects
None yet
Milestone
No milestone
2 participants
@omgitsjocke @jtracey93