Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleThreadEventExecutor shutdown takes long time #7

Closed
nayato opened this issue Jul 18, 2015 · 2 comments
Closed

SingleThreadEventExecutor shutdown takes long time #7

nayato opened this issue Jul 18, 2015 · 2 comments
Assignees
@nayato
Labels
bug

Comments

@nayato
Copy link
Member

nayato commented Jul 18, 2015

No description provided.

@nayato nayato self-assigned this Jul 18, 2015
@nayato nayato added the bug label Jul 28, 2015
@nayato
Copy link
Member Author

nayato commented Nov 22, 2015

Shut down happens, just not as quick as expected. Same is true in my tests with netty. I'd still want to revisit shutdown sequence so keeping this open.

@nayato nayato changed the title SingleThreadEventExecutor never shuts down gracefully SingleThreadEventExecutor shutdown takes long time Nov 22, 2015
@nayato nayato removed the bug label Nov 22, 2015
@nayato nayato closed this as completed Apr 12, 2016
@nayato nayato reopened this Apr 27, 2016
@nayato
Copy link
Member Author

nayato commented Apr 27, 2016

ShutdownGracefullyAsync regressed to not complete ever.

@nayato nayato mentioned this issue Apr 27, 2016
Merged
nayato added a commit to nayato/DotNetty that referenced this issue Apr 27, 2016
@nayato
Fixes ByteBuffer+Stream integration, TLS neg, STEE Shutdown
aa3cbc6 
Motivation:
Fix up top priority issues to ensure proper working state with recent changes.

Modifications:
- TlsHandler negotiates TLS 1.0+ on server side (Azure#89)
- STEE properly supports graceful shutdown (Azure#7)
- UnpooledHeapByteBuffer.GetBytes honors received index and length (Azure#88)
- Echo E2E test uses length-prefix based framing (Azure#90)

Result:
Setting up DotNetty does not require workarounds for shutdown and hacks to enable negotiation of higher versions of TLS. Tests are passing even with new SslStream behavior.
@nayato nayato closed this as completed Apr 27, 2016
@nayato nayato added the bug label Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nayato nayato

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nayato