Remove tools moved to base image #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker image sizes with this change: REPOSITORY TAG IMAGE ID CREATED SIZE
quay.io/surajd/cloudshell-tools suraj-reduce-tools-image-contents-53cfc40-2024-08-Aug-14-13-32-50 c336f3f4a1ac About an hour ago 6.94GB
quay.io/surajd/cloudshell suraj-reduce-tools-image-contents-53cfc40-2024-08-Aug-14-13-32-50 a8c78b8b7f00 About an hour ago 6.05GB |
|
Tested locally end-to-end. |
| POWERSHELL_UPDATECHECK=Off | ||
|
|
||
| # Copy and run script to install Powershell modules and setup Powershell machine profile | ||
| COPY ./linux/powershell/ powershell |
There was a problem hiding this comment.
Can merge everything in tools to base except "powershell" and az cli.
surajssd
force-pushed
the
suraj/reduce-tools-image-contents
branch
2 times, most recently
from
5a0bcae to
c0483b0
Compare
|
With the latest changes the file sizes are as: $ docker images
REPOSITORY TAG IMAGE ID CREATED SIZE
ghcr.io/surajssd/cloudshell/tools suraj-reduce-tools-image-contents-c0483b0-20240821-225233 fec921d743f7 29 minutes ago 7.24GB
ghcr.io/surajssd/cloudshell/base suraj-reduce-tools-image-contents-c0483b0-20240821-225233 8b7e8244234e 34 minutes ago 5.02GBTools and base has about 2.2GB difference. |
surajssd
force-pushed
the
suraj/reduce-tools-image-contents
branch
from
c0483b0 to
3e603c8
Compare
surajssd
changed the title
surajssd
changed the title
surajssd
force-pushed
the
suraj/reduce-tools-image-contents
branch
from
3e603c8 to
d2aacba
Compare
REPOSITORY TAG IMAGE ID CREATED SIZE
ghcr.io/surajssd/cloudshell/tools suraj-reduce-tools-image-contents-d2aacba-20240829-194858 bc2abc431591 About an hour ago 7.24GB
ghcr.io/surajssd/cloudshell/base suraj-reduce-tools-image-contents-d2aacba-20240829-194858 8a80d4c384cf 2 hours ago 5.02GB
|
Following components were moved to base image: - Ansible galaxy - vscode - Azure Developer CLI - Bicep This commit removes the installation of these components from the tools image. Signed-off-by: Suraj Deshmukh <[email protected]>
surajssd
force-pushed
the
suraj/reduce-tools-image-contents
branch
from
d2aacba to
0d350f4
Compare
surajssd
changed the title
Signed-off-by: Suraj Deshmukh <[email protected]>
Move the az extensions and tools installation right after the az cli is installed. Signed-off-by: Suraj Deshmukh <[email protected]>
The newer format for defining env var has changed format from: ``` ENV key val ``` to: ``` ENV key=val ``` Signed-off-by: Suraj Deshmukh <[email protected]>
Signed-off-by: Suraj Deshmukh <[email protected]>
Signed-off-by: Suraj Deshmukh <[email protected]>
|
Closed in favor of #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following components were moved to base image:
This commit removes the installation of these
components from the tools image.
Should be merged after the base image is cached with changes in #482 and the tools image has the tag of the new base.