Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update la-vminsights-readonly.bicep #408

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

obay
Copy link
Contributor

@obay obay commented Aug 25, 2024

Overview/Summary

Fixing an issue with action name typo

This PR fixes

Issue #404

la-vminsights-readonly.bicep line 37 has a typo.

Currently reads
'Microsoft.operationalinsights/workspaces/features/clientgroups/memebers/read'
should read
'Microsoft.operationalinsights/workspaces/features/clientgroups/members/read'

"Memebers" should be "Members"

Breaking Changes

None

Testing Evidence

/usr/bin/az account clear
Finishing: Custom Role - la-vminsights-readonly.bicep

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@obay obay linked an issue Aug 25, 2024 that may be closed by this pull request
@Vallentyne Vallentyne self-requested a review November 7, 2024 16:15
Copy link
Contributor

@Vallentyne Vallentyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Obay, good catch!

@Vallentyne Vallentyne merged commit 1cdd2dc into main Nov 7, 2024
2 checks passed
@Vallentyne Vallentyne deleted the 404-typo-in-rolesla-vminsights-readonly-bicep branch November 7, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in /roles/la-vminsights-readonly-bicep
2 participants