Fixed Linter warnings & build errors (#354) #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed BCP321 Linter warning in networking files * Fixed Role Definition Id References to use the ResourceId function * changed the pOlicyScopedId var to be set by using the MGResourceID Function * fixed BCP321 warning * fixed the remaining linter warnings * fixed the remaining linter errors in the policy definitions * updated the linter rules * Fixed Bug on policy defnition * Fixed the AKS policy deployment * Commit 95556ddd: changed the extensionResourceId function to tenantResourceId for all built-in polify definitions * fixed linter warnings in policy files * changed the invalid dummy service alert phone number to a valid phone number * changed the servcie health number prefix to 604 * updated AKS version in the Data Archetypes * Changed hte AKS version to only have the Major.Minor * Added the patch version to the AKS versions in the Data Archetypes
tredell
requested review from
hudua,
SenthuranSivananthan and
skeeler
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed BCP321 Linter warning in networking files
Fixed Role Definition Id References to use the ResourceId function
changed the pOlicyScopedId var to be set by using the MGResourceID Function
fixed BCP321 warning
fixed the remaining linter warnings
fixed the remaining linter errors in the policy definitions
updated the linter rules
Fixed Bug on policy defnition
Fixed the AKS policy deployment
Commit 95556ddd: changed the extensionResourceId function to tenantResourceId for all built-in polify definitions
fixed linter warnings in policy files
changed the invalid dummy service alert phone number to a valid phone number
changed the servcie health number prefix to 604
updated AKS version in the Data Archetypes
Changed hte AKS version to only have the Major.Minor
Added the patch version to the AKS versions in the Data Archetypes
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
mainbranch