Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for configuring Service connection in Azure DevOps #110

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

SenthuranSivananthan
Copy link
Contributor

Overview/Summary

Added step by step instructions for setting up Service connection in Azure DevOps.

Thanks @KingBain for raising this gap and providing the initial instructions.

This PR fixes/adds/changes/removes

  1. Related to Update ado.md #106

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@SenthuranSivananthan SenthuranSivananthan added the documentation Improvements or additions to documentation label Dec 1, 2021
@SenthuranSivananthan SenthuranSivananthan added this to the v0.6.0 milestone Dec 1, 2021
Copy link
Contributor

@hudua hudua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - looks good with two minor suggestions:

  1. Wording would be create service connection if no service connections exist yet
  2. Perhaps it would be helpful to add a sentence to leave grant access permission to all pipelines unchecked

docs/onboarding/ado.md Outdated Show resolved Hide resolved
docs/onboarding/ado.md Show resolved Hide resolved
Copy link
Contributor

@hudua hudua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@hudua hudua merged commit d48811f into Azure:main Dec 2, 2021
@SenthuranSivananthan SenthuranSivananthan deleted the ado-onboarding branch December 2, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants